Remove slashes from the end of charset tags #1293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, some scrapers (most notably Discord's OGP scraper) don't respect charset tags that do contain closing slashes.
|
There is a bunch of stuff about this issue out there on the web, e.g. https://superuser.com/questions/1048013/why-some-metatags-have-in-the-end-and-some-dont , not really sure what the most authoritative source of advice is on this, but afaict from the several things I read, the change is safe, given that our site is HTML and not XHTML. |
|
Assuming this fixes it, a corresponding PR over in the other repo (https://github.com/scala/docs.scala-lang/) would be welcome. |
|
I'll wait and see, and if it does fix it I'll do so 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, some scrapers (most notably Discord's OGP scraper) don't respect charset tags that do contain closing slashes.
Huge thanks to @adryd325 for taking the time to poke at Discord's scraper to figure this out.